CS-343 [New Framework] - PIPEDA, CS-333 [New Framework] - CCPA#2759
Merged
Conversation
chasprowebdev
changed the title
Contributor
|
@cubic-dev-ai please review this. |
Contributor
@chasprowebdev I have started the AI code review. It will take a few minutes to complete. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 11 files
Confidence score: 3/5
- There is a concrete functional risk:
packages/db/prisma/schema/trust.prismaadds PIPEDA/CCPA onTrust, butTrustFrameworkwas not updated to match, which can block certificate persistence inTrustResourcefor those frameworks. - Given the high severity/confidence signal (7/10, 9/10), this is more than a housekeeping mismatch and could produce user-facing gaps when handling new trust frameworks.
- Pay close attention to
packages/db/prisma/schema/trust.prisma- enum/model alignment is needed so new frameworks can be stored consistently.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="packages/db/prisma/schema/trust.prisma">
<violation number="1" location="packages/db/prisma/schema/trust.prisma:28">
P1: PIPEDA/CCPA were added on `Trust`, but `TrustFramework` was not extended, so TrustResource cannot store certificate entries for these new frameworks.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
Contributor
|
Contributor
|
@cubic-dev-ai please review this. |
Contributor
@chasprowebdev I have started the AI code review. It will take a few minutes to complete. |
Marfuen
approved these changes
May 7, 2026
Contributor
|
🎉 This PR is included in version 3.47.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated pull request to merge chas/add-PIPEDA-CCPA into dev.
It was created by the [Auto Pull Request] action.
Summary by cubic
Adds PIPEDA and CCPA as first-class frameworks across the Trust Center and public trust portal (Linear CS-343, CS-333). Users can toggle them, set status (incl. in-progress), upload/preview certificates, and see badges/logos.
New Features
pipeda,pipeda_status,ccpa,ccpa_statustoTrustand extendedTrustFrameworkwithpipeda/ccpa(migrations included).trust-portal.serviceandtrust-access.serviceto read/write PIPEDA/CCPA booleans and statuses, accept camelCase/snake_case, include them in settings payloads, and expose badge/label mappings./badges/pipeda.svg,/badges/ccpa.svg) shown in Frameworks Overview/Table. Trust page now passes PIPEDA/CCPA flags, statuses, and certificate filenames.Migration
Written for commit ff0ef54. Summary will update on new commits.